Upgrade Liquibase to 4.7.1 and substitute new OSGi and h2 bits #23118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
famod
commented
Jan 23, 2022
| private static String getBuildInfo(String propertyId) { | ||
| // this is a bit of a mess: we have to get rid of the entire first part that accesses osgi classes | ||
| // and only retain the second part | ||
| // taken from: https://github.com/liquibase/liquibase/blob/v4.7.1/liquibase-core/src/main/java/liquibase/util/LiquibaseUtil.java#L57-L91 |
There was a problem hiding this comment.
IMO, that copied code could be much simpler for Quarkus, but I rather copied it 1:1. Not sure what the general policy is here.
gsmet
approved these changes
Jan 24, 2022
|
I cannot promise anything but I'll think about how this can be improved on the Liquibase side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not pretty, but that was to be expected after #22785 (comment).
This is the first time I have implemented such substitutions, so maybe there is a more clever approach.
I basically went through the errors that popped up in the IT module and tried to fix them as good as I could.
I also checked the quickstart (with native) and my project (no native). Native image size of the quickstart is more or less the same.
I can also adjust the mongodb flavor. It appears to me that this module is pretty much c&p?I had to adjust liquibase-mongodb right away to keep CI happy.