Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show CLI version and useful text with base quarkus command #23159

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Show CLI version and useful text with base quarkus command #23159

merged 2 commits into from
Jan 25, 2022

Conversation

ebullient
Copy link
Contributor

Resolves #23067

  • CLI: Inherit headings and options from root command -- cleanup.
  • CLI: Add version/intro text to quarkus command

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Jan 25, 2022
gsmet
gsmet requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicking inline.

devtools/cli/src/main/java/io/quarkus/cli/QuarkusCli.java Outdated Show resolved Hide resolved
gsmet
gsmet approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed the last commit and force pushed. Looks good!

@gsmet gsmet merged commit 625af2e into quarkusio:main Jan 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 25, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging this pull request may close these issues.

Display Quarkus version in the Quarkus CLI
2 participants
@ebullient @gsmet