Add documentation to handle Java preview features for building natives #23172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Jan 25, 2022
| [NOTE] | ||
| .Java preview features | ||
| ==== | ||
| Java code might that relies on preview features requires special attention. |
There was a problem hiding this comment.
Suggested change
| Java code might that relies on preview features requires special attention. | |
| Java code that relies on preview features requires special attention. |
| ==== | ||
| Java code might that relies on preview features requires special attention. | ||
| To produce a native executable, this means that the `--enable-preview` flag needs to be passed to the underlying native image invocation. | ||
| You can do so by prepending the flag with `-J` and passing it as additional native builder argument: `-Dquarkus.native.additional-build-args=-J--enable-preview`. |
There was a problem hiding this comment.
Suggested change
| You can do so by prepending the flag with `-J` and passing it as additional native builder argument: `-Dquarkus.native.additional-build-args=-J--enable-preview`. | |
| You can do so by prepending the flag with `-J` and passing it as additional native build argument: `-Dquarkus.native.additional-build-args=-J--enable-preview`. |
| [NOTE] | ||
| .Java preview features | ||
| ==== | ||
| Java code might that relies on preview features requires special attention. |
There was a problem hiding this comment.
Suggested change
| Java code might that relies on preview features requires special attention. | |
| Java code that relies on preview features requires special attention. |
| ==== | ||
| Java code might that relies on preview features requires special attention. | ||
| To test a native executable, this means that the `--enable-preview` flag needs to be passed to surefire plugin. | ||
| Adding `<argLine>--enable-preview</argLine>` to surefire plugin `configuration` section is one way to do so. |
There was a problem hiding this comment.
Suggested change
| Adding `<argLine>--enable-preview</argLine>` to surefire plugin `configuration` section is one way to do so. | |
| Adding `<argLine>--enable-preview</argLine>` to the Surefire plugin `configuration` section is one way to do so. |
| .Java preview features | ||
| ==== | ||
| Java code might that relies on preview features requires special attention. | ||
| To test a native executable, this means that the `--enable-preview` flag needs to be passed to surefire plugin. |
There was a problem hiding this comment.
Suggested change
| To test a native executable, this means that the `--enable-preview` flag needs to be passed to surefire plugin. | |
| To test a native executable, this means that the `--enable-preview` flag needs to be passed to the Surefire plugin. |
galderz
force-pushed
the
t_native_java17_enable_preview
branch
from
b62361a
to
d04bc0b
Compare
galderz
force-pushed
the
t_native_java17_enable_preview
branch
from
d04bc0b
to
bc9bb38
Compare
|
@gsmet Fixed comments |
geoand
approved these changes
Jan 25, 2022
gsmet
approved these changes
Jan 25, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback in this Zulip stream.