Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - implement timeout for async rendering methods #23216

Merged
merged 1 commit into from Feb 1, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 26, 2022

  • introduce the "io.quarkus.qute.timeout" config property
  • improve the test coverage
  • ensure the JAX-RS response filters use the timeout as well
  • add TRACE logging to help to identify problematic parts of the
    template when a timeout occurs

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4067522

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Misc1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-classic/resteasy-qute/deployment 
! Skipped: integration-tests/qute 

📦 extensions/resteasy-classic/resteasy-qute/deployment

io.quarkus.qute.resteasy.deployment.MessageBundleDevModeTest.testMessageBundles - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.MessageBundleLocaleFromVariantTest.testMessageBundles - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.TemplateResponseFilterTest.testFilter - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.VariantTemplateTest.testVariant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy-qute/deployment 
! Skipped: integration-tests/qute 

📦 extensions/resteasy-classic/resteasy-qute/deployment

io.quarkus.qute.resteasy.deployment.MessageBundleDevModeTest.testMessageBundles - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.MessageBundleLocaleFromVariantTest.testMessageBundles - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.TemplateResponseFilterTest.testFilter - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.VariantTemplateTest.testVariant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-classic/resteasy-qute/deployment 
! Skipped: integration-tests/qute 

📦 extensions/resteasy-classic/resteasy-qute/deployment

io.quarkus.qute.resteasy.deployment.MessageBundleDevModeTest.testMessageBundles - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.MessageBundleLocaleFromVariantTest.testMessageBundles - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.TemplateResponseFilterTest.testFilter - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.qute.resteasy.deployment.VariantTemplateTest.testVariant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

⚙️ Native Tests - Misc1 #

- Failing: integration-tests/qute 

📦 integration-tests/qute

io.quarkus.it.qute.QuteITCase.testTemplates - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.it.qute.QuteITCase.testNotFoundPageStatusCode - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 27, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 74f1a3c

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 281 more

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.IncompletePostTestCase.testIncompleteWrite line 36 - More details - Source on GitHub

java.net.ConnectException: Connection refused: connect
	at java.base/java.net.PlainSocketImpl.connect0(Native Method)
	at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:101)

@mkouba mkouba added this to the 2.8 - main milestone Jan 28, 2022
@mkouba
Copy link
Contributor Author

mkouba commented Jan 28, 2022

The CI failure does not seem to be related...

- introduce the "io.quarkus.qute.timeout" config property
- improve the test coverage
- ensure the JAX-RS response filters use the timeout as well
- add TRACE logging to help to identify problematic parts of the
template when a timeout occurs

Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>
@gsmet gsmet merged commit a2f0e54 into quarkusio:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants