Move quarkus-devtools-utils and the codestarts artifact to the quarkus-bom #23267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/dependencies
gastaldi
reviewed
Jan 28, 2022
aloubyansky
force-pushed
the
quarkus-devtools-utils-bom
branch
from
738df4a
to
7526f31
Compare
quarkus-bot
bot
added
area/devtools
gastaldi
reviewed
Jan 28, 2022
| @@ -37,6 +37,7 @@ | |||
| <artifactId>quarkus-project-core-extension-codestarts</artifactId> | |||
| <type>pom</type> | |||
| <scope>test</scope> | |||
| <version>${project.version}</version> | |||
There was a problem hiding this comment.
Isn't better to keep this specific artifact in build-parent instead?
There was a problem hiding this comment.
We could. But then we could do the same for the rest of dependencies on POMs, e.g. https://github.com/quarkusio/quarkus/blob/main/integration-tests/amazon-lambda-http-resteasy-reactive/pom.xml#L40
gastaldi
approved these changes
Jan 28, 2022
|
Could we please get this backported to 2.7? |
gsmet
approved these changes
Jan 28, 2022
|
@ppalaga yep, it already has the label. |
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used by some core artifacts.