Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump font-awesome from 5.15.4 to 6.0.0 #23567

Merged
merged 1 commit into from Feb 10, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 9, 2022

Bumps font-awesome from 5.15.4 to 6.0.0.

Commits
  • 364f191 [maven-release-plugin] prepare release font-awesome-6.0.0
  • fc4af28 bump to 6.0.0 - fixes #68
  • 3736c95 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [font-awesome](https://github.com/webjars/font-awesome) from 5.15.4 to 6.0.0.
- [Release notes](https://github.com/webjars/font-awesome/releases)
- [Commits](webjars/font-awesome@font-awesome-5.15.4...font-awesome-6.0.0)

---
updated-dependencies:
- dependency-name: org.webjars:font-awesome
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Feb 9, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 10, 2022

Failing Jobs - Building 503c876

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/project-core-extension-codestarts extensions/hibernate-search-orm-elasticsearch/deployment 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/maven and 178 more

📦 devtools/project-core-extension-codestarts

Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (generate-gradle-wrapper) on project quarkus-project-core-extension-codestarts: Command execution failed.

📦 extensions/hibernate-search-orm-elasticsearch/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.39.0:start (docker-start) on project quarkus-hibernate-search-orm-elasticsearch-deployment: I/O Error

@gastaldi gastaldi merged commit 2878a84 into main Feb 10, 2022
@gastaldi gastaldi deleted the dependabot/maven/org.webjars-font-awesome-6.0.0 branch February 10, 2022 20:56
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 10, 2022
@gsmet
Copy link
Member

gsmet commented Feb 21, 2022

@gastaldi just to make sure, have you tested the Dev UI with this update? (given it's a major version, there might be breaking changes in how the icons are handled)

@gastaldi
Copy link
Contributor

@gsmet I remember testing #23636 which AFAIR had this change already and seemed to work. Have you found any incompatibility in the update?

@gsmet
Copy link
Member

gsmet commented Feb 21, 2022

Nope, just wanted to make sure it was visually tested. If so, all good for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/component-upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants