Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't copy static methods to CDI Wrapper of REST Client #23830

Merged
merged 1 commit into from Feb 21, 2022
Merged

Don't copy static methods to CDI Wrapper of REST Client #23830

merged 1 commit into from Feb 21, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 21, 2022

Fixes: #23766

@geoand geoand mentioned this pull request Feb 21, 2022
Closed
gsmet
gsmet approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@geoand geoand merged commit 912116d into quarkusio:main Feb 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 21, 2022
@geoand geoand deleted the #23766 branch February 21, 2022 10:48
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
@michalszynkiewicz
Copy link
Member

LGTM. I was afraid that it could impact Fault Tolerance + Rest Client but checked and it doesn't seem to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@michalszynkiewicz michalszynkiewicz Awaiting requested review from michalszynkiewicz

Assignees
No one assigned
Labels
area/resteasy-reactive kind/bugfix
Projects
None yet
Milestone
2.7.2.Final
Development

Successfully merging this pull request may close these issues.

Unable to use @ClientExceptionMapper in native build
3 participants
@geoand @michalszynkiewicz @gsmet