Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: include test sources in the ApplicationModel for dev mode #23839

Merged

Conversation

aloubyansky
Copy link
Member

Fix #23735

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven labels Feb 21, 2022
@gsmet
Copy link
Member

gsmet commented Feb 21, 2022

@glefloch it would be nice if you could have a look at this one today as I'm releasing 2.7.2.Final tomorrow morning and it looks like a serious regression.

Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glefloch glefloch added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 21, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 21, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 70f1557

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/maven 
! Skipped: devtools/cli integration-tests/amazon-lambda integration-tests/amazon-lambda-http and 174 more

📦 devtools/maven

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-maven-plugin: Imports are not sorted in /home/runner/work/quarkus/quarkus/devtools/maven/src/main/java/io/quarkus/maven/QuarkusMavenWorkspaceBuilder.java

@glefloch glefloch force-pushed the gradle-include-test-sources-in-dev-model branch from 70f1557 to b7cff8f Compare February 21, 2022 13:15
@glefloch
Copy link
Member

I amended the commit with formatting.

@aloubyansky
Copy link
Member Author

Thanks @glefloch!

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 21, 2022

Failing Jobs - Building b7cff8f

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in com.example.grpc.hibernate.BlockingRawTest that uses java.util.List was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@glefloch
Copy link
Member

The failure doesn't seem to be related.

@gsmet gsmet merged commit d8879f6 into quarkusio:main Feb 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 21, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 21, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle Unit Tests Don't Work Since 2.7.1
3 participants