New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkiverse extensions can build on other OSes too #23889
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 4096d94
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/vertx/deployment
! Skipped: core/test-extension/deployment extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 315 more 📦 extensions/vertx/deployment✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming tests passes lgtm
...ain/resources/codestarts/quarkus-extension/code/quarkiverse/java/.github/workflows/build.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to open a debate, please dismiss if you think it's useless.
Is it really a good thing to multiply our CI usage by 3, when in most cases this will have little value? I would think it could be enabled by the Quarkiverse authors when they think it makes sense for their libraries (we had one so far AFAICS).
Also, we wanted to enable native testing by default for Quarkiverse extensions and it will require some non trivial work with Windows in the matrix.
So if we decide to do that, I think we should add native testing on Linux (and I would limit it to Linux for the default behavior) because it might not be easy for the Quarkiverse contributor to do it afterwards with this new setup.
Btw this question:
|
...ain/resources/codestarts/quarkus-extension/code/quarkiverse/java/.github/workflows/build.yml
Show resolved
Hide resolved
I wouldn't be against having this matrix setup with Linux by default and a commented line with Linux/Windows. I see little value in testing with macOS in the Java world, except in very specific cases. |
You are right @gsmet it does not make sense to enable This for All by default. Maybe parameteriZe the matrix and let users enable whats needed. Osx is relevant for native but yes; not by default. |
@gsmet The reason why I am doing this is because some Quarkiverse builds were reported to fail in Windows (see quarkiverse/quarkus-openapi-generator#7). But I agree that it wouldn't be necessary from day one. I like your suggestion of having the matrix setup with Linux by default and some commented out lines for Windows. I also agree that testing in macOS is not very valuable (perhaps if one likes to investigate |
Yes, I have seen that, that's the one occurrence I was referencing to. I'm just unsure we should generalize this based on a few occurrences where it makes absolutely sense. CI has a cost, even if it appears free to us, and I think we should try to be good citizens about it when we can. |
Use actions/setup-java's cache
4096d94
to
e5394bf
Compare
This PR introduces some improvements to Quarkiverse extensions' build script: