Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated code #23926

Merged
merged 1 commit into from Feb 25, 2022
Merged

Remove duplicated code #23926

merged 1 commit into from Feb 25, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Feb 23, 2022

Reuses split() method in ArtifactKey

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Feb 23, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 23, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8c5a3ce

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/bootstrap/app-model 
! Skipped: core/deployment core/launcher core/runtime and 702 more

📦 independent-projects/bootstrap/app-model

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-bootstrap-app-model: Imports are not sorted in /home/runner/work/quarkus/quarkus/independent-projects/bootstrap/app-model/src/main/java/io/quarkus/bootstrap/model/AppArtifactCoords.java

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 23, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 24, 2022

Failing Jobs - Building 028becb

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.InjectQuarkusAppPropertiesDevModeTest.main line 19 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@Sanne Sanne merged commit 72bf0d2 into quarkusio:main Feb 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 25, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 25, 2022
@gastaldi gastaldi deleted the dups branch May 10, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants