Make sure @ClientExceptionMapper works properly in native mode #23936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // this isn't used, but it makes sure that the generated provider can be properly instantiated in native mode | ||
| @ClientExceptionMapper | ||
| static RuntimeException toException(Response response) { |
There was a problem hiding this comment.
can we use it instead?
In the future we may have other native bugs in this and having half of the test already written maybe it's worth going all the way?
There was a problem hiding this comment.
Yeah, I'll certainly add the rest of the test in the future :)
michalszynkiewicz
approved these changes
Feb 25, 2022
|
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23766