Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Keycloak version to 17.0.0 #24108

Merged
merged 1 commit into from Mar 8, 2022

Conversation

sberyozkin
Copy link
Member

Keycloak 17.0.0 is now based on Quarkus. Wildfly-based distro has a -legacy version qualifier. So I had to tweak a bit the way DevServices for Keycloak detect that it is a non WildFly based Keycloak image.

Most of the integration tests still use the WildFly based KC for tests since RH SSO will be based on it for a bit longer.
integration-tests/oidc is totally Keycloak(-X), and so all 3 quickstarts, but I'll follow with the related quickstart doc updates

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 4, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0eb9655

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/oidc-client-filter/deployment 
! Skipped: integration-tests/oidc-client integration-tests/oidc-client-wiremock integration-tests/oidc-token-propagation 

📦 extensions/oidc-client-filter/deployment

io.quarkus.oidc.client.filter.OidcClientFilterDevModeTest.testGetUserName - More details - Source on GitHub

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource io.quarkus.test.keycloak.server.KeycloakTestResourceLifecycleManager@713476f2
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-filter/deployment 
! Skipped: integration-tests/oidc-client integration-tests/oidc-client-wiremock integration-tests/oidc-token-propagation 

📦 extensions/oidc-client-filter/deployment

io.quarkus.oidc.client.filter.OidcClientFilterDevModeTest.testGetUserName - More details - Source on GitHub

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource io.quarkus.test.keycloak.server.KeycloakTestResourceLifecycleManager@51ae9297
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 5, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building aa3ed52

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
Native Tests - Data7 Download Maven Repo ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in com.example.grpc.hibernate.BlockingRawTest that uses java.util.List was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-reactive-messaging-amqp/deployment 
! Skipped: integration-tests/reactive-messaging-amqp 

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest.test line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@sberyozkin
Copy link
Member Author

The failures are not related, but in any case I'll update the quickstart docs in this PR

@sberyozkin sberyozkin force-pushed the keycloak-17.0.0 branch 2 times, most recently from b8aecda to 11a9f53 Compare March 6, 2022 15:59
@sberyozkin sberyozkin marked this pull request as draft March 6, 2022 16:03
@sberyozkin sberyozkin force-pushed the keycloak-17.0.0 branch 2 times, most recently from 5c89d26 to 8237c77 Compare March 7, 2022 14:32
@sberyozkin sberyozkin marked this pull request as ready for review March 7, 2022 14:32
@sberyozkin
Copy link
Member Author

A corresponding Qucikstarts PR: quarkusio/quarkus-quickstarts#1073
Starting a container will be simpler once the certs are generated in a dev mode

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 7, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8237c77

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/container-image/maven-invoker-way 

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-with-keycloak

org.acme.security.openid.connect.NativeBearerTokenAuthenticationIT.testAdminAccess - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
Caused by: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

org.acme.security.openid.connect.NativeBearerTokenAuthenticationIT.testAdminAccess - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
Caused by: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

@sberyozkin
Copy link
Member Author

I only did a minor doc update to restart the build, the container test was fine locally:

[INFO] [INFO] [io.quarkus.container.image.jib.deployment.JibProcessor] Created container image sberyozkin/container-build-with-keycloak:0.1-SNAPSHOT (sha256:9db26e0eca1354d8f2fe2c5dedd6e903230d8648ce6a9b6ae09f5bcb4e20a7ca)
[INFO] 
[INFO] [INFO] [io.quarkus.deployment.QuarkusAugmentor] Quarkus augmentation completed in 14790ms
[INFO] [INFO] 
[INFO] [INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (default) @ container-build-with-keycloak ---
[INFO] [INFO] 
[INFO] [INFO] -------------------------------------------------------
[INFO] [INFO]  T E S T S
[INFO] [INFO] -------------------------------------------------------
[INFO] [INFO] Running org.acme.security.openid.connect.NativeBearerTokenAuthenticationIT
[INFO] 2022-03-07 21:09:49,152 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final
[INFO] 2022-03-07 21:09:49,476 INFO  [org.tes.doc.DockerClientProviderStrategy] (build-3) Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first
[INFO] 2022-03-07 21:09:49,852 INFO  [org.tes.doc.DockerClientProviderStrategy] (build-3) Found Docker environment with local Unix socket (unix:///var/run/docker.sock)
[INFO] 2022-03-07 21:09:49,853 INFO  [org.tes.DockerClientFactory] (build-3) Docker host IP address is localhost
[INFO] 2022-03-07 21:09:49,869 INFO  [org.tes.DockerClientFactory] (build-3) Connected to docker: 
[INFO]   Server Version: 18.06.1-ce
[INFO]   API Version: 1.38
[INFO]   Operating System: Fedora 27 (Workstation Edition)
[INFO]   Total Memory: 31542 MB
[INFO] 2022-03-07 21:09:49,872 INFO  [org.tes.uti.ImageNameSubstitutor] (build-3) Image name substitution will be performed by: DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')
[INFO] 2022-03-07 21:09:51,082 INFO  [org.tes.DockerClientFactory] (build-3) Ryuk started - will monitor and terminate Testcontainers containers on JVM exit
[INFO] 2022-03-07 21:09:51,276 INFO  [io.qua.oid.dep.dev.key.KeycloakDevServicesProcessor] (build-3) Using Quarkus powered Keycloak distribution
[INFO] 2022-03-07 21:09:51,300 INFO  [🐳 .io/.0.0]] (build-3) Creating container for image: quay.io/keycloak/keycloak:17.0.0
[INFO] 2022-03-07 21:09:51,515 INFO  [🐳 .io/.0.0]] (build-3) Container quay.io/keycloak/keycloak:17.0.0 is starting: f7976c5e368065d2b1df9a0bc862cc645779335160ee6b1b51449cec7fc438cf
[INFO] 2022-03-07 21:10:02,515 INFO  [🐳 .io/.0.0]] (build-3) Container quay.io/keycloak/keycloak:17.0.0 started in PT11.237372S
[INFO] 2022-03-07 21:10:04,420 INFO  [io.qua.oid.dep.dev.key.KeycloakDevServicesProcessor] (build-3) Dev Services for Keycloak started.
[INFO] Executing "docker run --name quarkus-integration-test-kgKDr --rm -p 8081:8081 -p 8444:8444 --net=ea18d09c135a206c676662c7894f10f35c95dcb766f8f836d692ad192d23de4d --env QUARKUS_HTTP_PORT=8081 --env QUARKUS_HTTP_SSL_PORT=8444 --env TEST_URL=http://localhost:8081 --env QUARKUS_OIDC_CLIENT_ID=backend-service --env CLIENT_QUARKUS_OIDC_AUTH_SERVER_URL=http://localhost:39411/realms/quarkus --env KEYCLOAK_URL=http://keycloak-YaTBt:8080 --env QUARKUS_OIDC_AUTH_SERVER_URL=http://keycloak-YaTBt:8080/realms/quarkus --env QUARKUS_OIDC_APPLICATION_TYPE=service --env QUARKUS_OIDC_CREDENTIALS_SECRET=secret sberyozkin/container-build-with-keycloak:0.1-SNAPSHOT"
[INFO] [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.707 s - in org.acme.security.openid.connect.NativeBearerTokenAuthenticationIT
[INFO] [INFO] 
[INFO] [INFO] Results:
[INFO] [INFO] 
[INFO] [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a quick look at the suggestions? They are minor but let's be consistent.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 8, 2022

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building ddceca3

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build ⚠️ Check → Logs Raw logs
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 8, 2022

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building f5a4a7a

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build ⚠️ Check → Logs Raw logs
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs

@sberyozkin sberyozkin merged commit 816984c into quarkusio:main Mar 8, 2022
@sberyozkin sberyozkin deleted the keycloak-17.0.0 branch March 8, 2022 17:52
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 8, 2022
@rsvoboda
Copy link
Member

@sberyozkin I think https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.8 should be enhanced with Keycloak section.

It's a noticeable change, base image changed, URL of the service changed, docker commands and admin/password properties are different, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants