New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Keycloak version to 17.0.0 #24108
Conversation
9f460df
to
0eb9655
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0eb9655
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/oidc-client-filter/deployment
! Skipped: integration-tests/oidc-client integration-tests/oidc-client-wiremock integration-tests/oidc-token-propagation 📦 extensions/oidc-client-filter/deployment✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/oidc-client-filter/deployment
! Skipped: integration-tests/oidc-client integration-tests/oidc-client-wiremock integration-tests/oidc-token-propagation 📦 extensions/oidc-client-filter/deployment✖
|
0eb9655
to
aa3ed52
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building aa3ed52
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/grpc-hibernate
📦 integration-tests/grpc-hibernate✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
|
The failures are not related, but in any case I'll update the quickstart docs in this PR |
b8aecda
to
11a9f53
Compare
5c89d26
to
8237c77
Compare
A corresponding Qucikstarts PR: quarkusio/quarkus-quickstarts#1073 |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 8237c77
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ 📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-with-keycloak✖
✖
|
8237c77
to
f04863b
Compare
I only did a minor doc update to restart the build, the container test was fine locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a quick look at the suggestions? They are minor but let's be consistent.
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
f5a4a7a
to
1a63564
Compare
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
@sberyozkin I think https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.8 should be enhanced with Keycloak section. It's a noticeable change, base image changed, URL of the service changed, docker commands and admin/password properties are different, ... |
Keycloak 17.0.0 is now based on Quarkus. Wildfly-based distro has a
-legacy
version qualifier. So I had to tweak a bit the wayDevServices for Keycloak
detect that it is a non WildFly based Keycloak image.Most of the integration tests still use the WildFly based KC for tests since RH SSO will be based on it for a bit longer.
integration-tests/oidc
is totally Keycloak(-X), and so all 3 quickstarts, but I'll follow with the related quickstart doc updates