Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make formatter and impsort cache version-specific #24168

Merged
merged 1 commit into from Mar 8, 2022
Merged

Make formatter and impsort cache version-specific #24168

merged 1 commit into from Mar 8, 2022

Conversation

famod
Copy link
Member

@famod famod commented Mar 8, 2022

Avoids inconsistencies like this one: #23944 (comment)

The obvious downside is that on plugin update, obsolete cache files of the older version remain present.
But then again those plugins are updated only rarely. Btw, formatter cache file for core-deployment is ~88k.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 8, 2022
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 8, 2022
@gastaldi
Copy link
Contributor

gastaldi commented Mar 8, 2022

The obvious downside is that on plugin update, obsolete cache files of the older version remain present.

Maybe we could delete the .cache dir when mvn clean -DdeleteCache is used?

Or always delete it with mvn clean and introduce a -DkeepCache instead

@gsmet
Copy link
Member

gsmet commented Mar 8, 2022

I think it's not that big of a problem.

@gsmet gsmet merged commit 3aeccd4 into quarkusio:main Mar 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 8, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 8, 2022
@famod
Copy link
Member Author

famod commented Mar 8, 2022

The obvious downside is that on plugin update, obsolete cache files of the older version remain present.

Maybe we could delete the .cache dir when mvn clean -DdeleteCache is used?

Doable, but same problem as merely documenting the find + rm command: hard to find.

Or always delete it with mvn clean and introduce a -DkeepCache instead

Not removing it via clean was the sole purpose of moving it to .cache outside of target.
quickly is using clean by default and I suppose hardly anyone would use/know that custom flag.

Another possibility would be (on clean) to remove everything in .cache except the folders for the current version
But that's pretty verbose with Maven...

@famod famod deleted the formatter-cache-version branch March 8, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants