Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -H:PrintAnalysisCallTreeType=CSV to generate csv call tree files #24268

Merged
merged 1 commit into from Mar 18, 2022

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Mar 11, 2022

@zakkak zakkak force-pushed the fix-20733 branch 2 times, most recently from c7d99ed to b872464 Compare March 16, 2022 13:54
@zakkak zakkak requested a review from galderz March 16, 2022 13:55
@zakkak zakkak marked this pull request as ready for review March 16, 2022 13:55
@gsmet gsmet merged commit 7f1aab3 into quarkusio:main Mar 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 18, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 18, 2022
@gsmet
Copy link
Member

gsmet commented Mar 18, 2022

Thanks!

@zakkak zakkak deleted the fix-20733 branch March 21, 2022 08:34
@zakkak
Copy link
Contributor Author

zakkak commented Mar 21, 2022

Marked this for backport to 2.7 as the flag is going to land in 21.3.2 as well which 2.7 will be compatible with.

if (graalVMVersion.isOlderThan(GraalVM.Version.VERSION_21_3_2)) {
nativeImageArgs.add("-H:+PrintAnalysisCallTree");
} else {
nativeImageArgs.add("-H:PrintAnalysisCallTreeType=CSV");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak can you confirm that having -H:PrintAnalysisCallTreeType=CSV triggers -H:+PrintAnalysisCallTree and we don't need to add it explicitly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It happens here.

@gsmet gsmet modified the milestones: 2.8.0.CR1, 2.7.6.Final May 5, 2022
@rsvoboda
Copy link
Member

@zakkak I think src/main/asciidoc/native-reference.adoc should be enhanced to mention this is enabled by default and additional-build-args is not needed anymore

https://quarkus.io/guides/native-reference#call-tree-reports

@zakkak
Copy link
Contributor Author

zakkak commented Jun 14, 2022

Good point @rsvoboda

Documentation updated in #26133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default native reports to CSV
3 participants