Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect container runtime in when using Jib #24291

Merged
merged 1 commit into from Mar 14, 2022
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 14, 2022

@geoand this is a conservative backport of your container runtime detection PR for 2.7. WDYT?

The detection uses the same method Quarkus already
used when building the native binary using a container build

Fixes: #24231
(cherry picked from commit a6745e0)

The detection uses the same method Quarkus already
used when building the native binary using a container build

Fixes: quarkusio#24231
(cherry picked from commit a6745e0)
@gsmet gsmet added this to the 2.7.5.Final milestone Mar 14, 2022
@gsmet gsmet requested a review from geoand March 14, 2022 08:39
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 14, 2022

Failing Jobs - Building 35d11ed

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

@gsmet gsmet merged commit 124d8f0 into quarkusio:2.7 Mar 14, 2022
@jesperpedersen
Copy link

Thanks guys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants