Ease restriction on native-sources type and container image extension #24352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iocanel the first commit probably needs a careful check |
gastaldi
reviewed
Mar 16, 2022
...r/deployment/src/main/java/io/quarkus/container/image/docker/deployment/DockerProcessor.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Mar 16, 2022
...r/deployment/src/main/java/io/quarkus/container/image/docker/deployment/DockerProcessor.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Mar 16, 2022
...age-jib/deployment/src/main/java/io/quarkus/container/image/jib/deployment/JibProcessor.java
Outdated
Show resolved
Hide resolved
The build now only fails when the package type is set to native-sources and one of the container image extensions would actually perform a container build. Fixes: quarkusio#24351
|
@iocanel mind taking a look at this one please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build now only fails when the package type is set to native-sources
and one of the container image extensions would actually perform a
container build.
Fixes: #24351