Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure correct runtime configuration is resolved before running quarkusGenerateCode #24512

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

glefloch
Copy link
Member

This makes sure the correct runtime configuration is resolved before the task is run.

close #24260

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Mar 23, 2022
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glefloch !

@aloubyansky aloubyansky merged commit a2278b2 into quarkusio:main Mar 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Mar 24, 2022
@glefloch glefloch deleted the fix/24260 branch March 24, 2022 19:21
@gsmet gsmet changed the title Make sure correct runtime configuration is resolve before running quarkusGenerateCode Make sure correct runtime configuration is resolved before running quarkusGenerateCode Mar 26, 2022
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.0.Final Mar 28, 2022
@gsmet gsmet modified the milestones: 2.8.0.Final, 2.7.6.Final May 5, 2022
@gsmet gsmet modified the milestones: 2.7.6.Final, 2.8.0.Final May 5, 2022
@gsmet
Copy link
Member

gsmet commented May 5, 2022

@glefloch I tried to backport that one and I end up with compilation issues. I'm not sure if it's easily fixable without backporting significant changes that we wouldn't want in 2.7. Any chance you could have a look and tell me if things are easy to sort out or not?

@glefloch
Copy link
Member Author

glefloch commented May 5, 2022

Yes sure, looking at it.

@glefloch
Copy link
Member Author

glefloch commented May 5, 2022

It should be that hard, I will push a backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle quarkusGenerateCode task with composite build dependency causes jar does not exist
3 participants