Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mariadb-java-client from 2.7.5 to 3.0.4 #24570

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Upgrade mariadb-java-client from 2.7.5 to 3.0.4 #24570

merged 1 commit into from
Mar 26, 2022

Conversation

famod
Copy link
Member

@famod famod commented Mar 25, 2022

https://mariadb.com/docs/release-notes/mariadb-connector-j-3-0/3-0-4/

Another try, after #23249 and #23530. The issues that popped up back then have been addressed, AFAICS.
A quick test run in my project didn't reveal any issues (just more WARN-chattiness by org.mariadb.jdbc.message.server.ErrorPacket).

@famod famod requested review from Sanne and gsmet March 25, 2022 22:28
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Mar 25, 2022
@famod
Copy link
Member Author

famod commented Mar 25, 2022

Btw, no changes compared to #23249 except for the version property.

@gsmet
Copy link
Member

gsmet commented Mar 26, 2022

just more WARN-chattiness by org.mariadb.jdbc.message.server.ErrorPacket

@famod but does that mean you end up with WARN messages in your logs for normal operations?

@famod
Copy link
Member Author

famod commented Mar 26, 2022

@gsmet not in general, but I saw two warnings on a clean DB when liquibase runs for the first time. It was warning that DATABASECHANGELOG doesn't exist (and the lock table).
Other than that I saw (additional) warnings when a constraint was violated and stuff like that.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@gsmet gsmet merged commit b051eb9 into quarkusio:main Mar 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Mar 26, 2022
@gsmet
Copy link
Member

gsmet commented Mar 26, 2022

I see you asked for a backport. Is there anything pressing in the upgrade?

@famod
Copy link
Member Author

famod commented Mar 26, 2022

Well, not really. Fits a .0 rather well?
Would have been ideal/better for CR but they don't seem to obey the Quarkus release schedule. 😉

I'm not sure there will be any changes to the 2.x driver.
Are we back to more or less monthly Quarkus releases? If yes 2.9.0 won't be that far away, so ok for me.

@famod famod deleted the mariadb-client-3.0.4 branch March 26, 2022 19:45
@gsmet
Copy link
Member

gsmet commented Mar 26, 2022

Yeah we are back to regular cycles. I'm on the verge for this one, I'll decide when doing the backport round :).

@gsmet gsmet modified the milestones: 2.9 - main, 2.8.0.Final Mar 28, 2022
@famod
Copy link
Member Author

famod commented Apr 5, 2022

Thanks for backporting, @gsmet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants