Add closeBootstrappedApp mojo param to QuarkusBootstrapMojo #24634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
famod
reviewed
Mar 30, 2022
devtools/maven/src/main/java/io/quarkus/maven/QuarkusBootstrapMojo.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
aloubyansky
force-pushed
the
closeBootstrappedApp
branch
from
8ae720d
to
34d8b0b
Compare
This comment has been minimized.
This comment has been minimized.
quarkus-bot
bot
added
triage/invalid
|
Sorry, wrong button. @gsmet could it be that the moved test-extension is missing |
This comment has been minimized.
This comment has been minimized.
aloubyansky
force-pushed
the
closeBootstrappedApp
branch
from
34d8b0b
to
cc6ba4a
Compare
aloubyansky
force-pushed
the
closeBootstrappedApp
branch
from
cc6ba4a
to
f8c3a68
Compare
famod
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24026 apparently resulted in
quarkus:generate-codeinvoked from theDevMojoto close the bootstrapped app because the Maven session listener isn't initialized from the invoker, making theDevMojoto bootstrap it again.This PR introduces a parameter that allows
DevMojoto instructquarkus:generate-codeto keep the bootstrapped app open.