Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Maven to 3.8.5 and maven-invoker to 3.1.0 #24655

Closed
wants to merge 1 commit into from
Closed

Update Maven to 3.8.5 and maven-invoker to 3.1.0 #24655

wants to merge 1 commit into from

Conversation

famod
Copy link
Member

@famod famod commented Mar 30, 2022

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 30, 2022
@famod
Copy link
Member Author

famod commented Mar 30, 2022

There is a strange failure in my fork, let's see what CI has to say here...

@quarkus-bot

This comment has been minimized.

Sign in to view
@famod
Copy link
Member Author

famod commented Mar 31, 2022

Those enforcer tests seem to be running into MNG-7432. I'll fix it tonight.

@famod famod requested a review from aloubyansky March 31, 2022 22:17
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Apr 1, 2022

@famod CI looks happy. I'll let you fix the typos. Can you make sure we can still build a generated Quarkus project with Maven 3.8.4?

@famod
Copy link
Member Author

famod commented Apr 1, 2022 •
edited

@gsmet I've build the liquibase-quickstart with both 3.8.4 and 3.8.5, as well as the result of:

mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=mvn-test \
    -Dextensions=resteasy-reactive,jib

(with version set to 999-SNAPSHOT)

Btw, we could add another Maven version to the Maven test job matrix. Or we could add a new nighly job,

@famod famod requested a review from gsmet April 3, 2022 19:06
@aloubyansky
Copy link
Member

Do we really want to promote 3.8.5 in the generated projects?

@famod
Copy link
Member Author

famod commented Apr 3, 2022

Do we really want to promote 3.8.5 in the generated projects?

I was on the fence about that. But I think we should promote the version we "depend" on.

@aloubyansky
Copy link
Member

I thought you wanted to make sure we are only compatible with 3.8.5. I am not sure we should make it our direct dependency.

@famod
Copy link
Member Author

famod commented Apr 3, 2022

I thought you wanted to make sure we are only compatible with 3.8.5

Well, haven't thought about it that way around. If you think that's better I can adjust the PR.
Thing is, while MNG-7432 does affect us, other fixes in 3.8.5 might be beneficial to have... 🤔

@aloubyansky
Copy link
Member

Unless you think other fixes outweigh the bug you hit, I wouldn't upgrade to 3.8.5. Making sure we can still build with it will be great though.

@famod
Copy link
Member Author

famod commented Apr 3, 2022 •
edited

I'll create another PR so that you guys can decide.

Btw, I don't think we can prevent MNG-7432 from happening, even when staying on 3.8.4 dependency-wise.

@aloubyansky
Copy link
Member

Btw, I don't think we can prevent MNG-7432 from happening, even when staying on 3.8.4 dependency-wise.

That's true.

@famod famod mentioned this pull request Apr 3, 2022
Merged
@famod
Copy link
Member Author

famod commented Apr 5, 2022

#24729 was merged instead.

@famod famod closed this Apr 5, 2022
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport? labels Apr 5, 2022
@famod famod deleted the mvn-3.8.5 branch April 5, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky Awaiting requested review from aloubyansky

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create examples with Maven 3.8.5
3 participants
@famod @gsmet @aloubyansky