Correct -Dstart-containers guard so that it still works if -DskipTests is set to false in container-image/maven-invoker-way
#25253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, unless start-containers is also set; do not run ITs unless enabled by the flag
holly-cummins
changed the title
-Dstart-containers guard so that it still works if -DskipTests is set to false-Dstart-containers guard so that it still works if -DskipTests is set to false in container-image/maven-invoker-way
gsmet
approved these changes
May 2, 2022
holly-cummins
deleted the
quarkus-integration-test-container-image-invoker-guard
branch
|
Forgot to link to the issue in my comment; this fixes #25231. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
-Dstart-containersguard so that it still works as intended if-DskipTestsis set to false on the command line-DskipTestsand-DskipITsif-Dstart-containersis set (so we won't suddenly launch ITs if-DskipITs=true-Dstart-containersrather than blanket OS bans), and we should avoid multiple conditions in profile activation since they'reORbefore mvn 3.2.2, andANDafter, which is just upsetting.