Type-safe messages - declare io.quarkus.qute.i18n.Message.value() as optional #25276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
force-pushed
the
feature/type-safe-messages-optional-message-value
branch
2 times, most recently
from
2786e20
to
25e8b21
Compare
mkouba
reviewed
May 2, 2022
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/MessageBundleBuildItem.java
Show resolved
Hide resolved
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/MessageBundleProcessor.java
Outdated
Show resolved
Hide resolved
extensions/qute/runtime/src/main/java/io/quarkus/qute/i18n/Message.java
Outdated
Show resolved
Hide resolved
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/MessageBundleProcessor.java
Outdated
Show resolved
Hide resolved
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/MessageBundleProcessor.java
Outdated
Show resolved
Hide resolved
extensions/qute/runtime/src/main/java/io/quarkus/qute/i18n/Message.java
Outdated
Show resolved
Hide resolved
michalvavrik
force-pushed
the
feature/type-safe-messages-optional-message-value
branch
from
25e8b21
to
586fde8
Compare
|
@mkouba thank you these are all good points, I pushed changes. |
mkouba
approved these changes
May 5, 2022
|
@michalvavrik Merged, thanks! |
|
@michalvavrik Would you care to send a follow-up PR and update the docs accordingly? |
|
@mkouba I can add an example and explain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17857
This PR makes
io.quarkus.qute.i18n.Message#value()optional. As a consequence, user can specify message templates for default locale only via localized file (that wasn't possible for Type-safe Message Bundles till now). When user provides message template both viaio.quarkus.qute.i18n.Message#value()and localized file,io.quarkus.qute.i18n.Message#value()value is preferred. Validation is in place, thus if value is not specified at all, exception is thrown. cc @mkouba