Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct some minor errors in security-openid-connect guide #25286

Merged
merged 1 commit into from May 6, 2022
Merged

Correct some minor errors in security-openid-connect guide #25286

merged 1 commit into from May 6, 2022

Conversation

aona42
Copy link
Contributor

@aona42 aona42 commented Apr 30, 2022

Maybe I misunderstand it, but using http://localhost:8180 like for alice a few lines above seems more logical to me.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 30, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@aona42 aona42 changed the title adjust keycloak URL for example Adjust keycloak URL for example Apr 30, 2022
@aona42 aona42 changed the title Adjust keycloak URL for example WIP: Adjust keycloak URL for example Apr 30, 2022
@aona42 aona42 changed the title WIP: Adjust keycloak URL for example WIP: Adjust keycloak URL and non-existing config option Apr 30, 2022
@aona42 aona42 marked this pull request as draft April 30, 2022 18:09
@aona42 aona42 changed the title WIP: Adjust keycloak URL and non-existing config option Adjust keycloak URL and non-existing config option Apr 30, 2022
sberyozkin
sberyozkin approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it was probably a copy and paste problem, keycloak-authorization guide uses HTTPS

@sberyozkin
Copy link
Member

Will check other changes once this PR is actually open for a review

@aona42
Copy link
Contributor Author

aona42 commented Apr 30, 2022

@sberyozkin Thanks for the feedback. I am still playing around with this guide, but I have the feeling, it needs a bit more rework, cause some things are not working for me.

@aona42 aona42 changed the title Adjust keycloak URL and non-existing config option Correct some minor errors in security-openid-connect guide May 1, 2022
@aona42 aona42 marked this pull request as ready for review May 1, 2022 05:52
@aona42 aona42 requested a review from sberyozkin May 1, 2022 05:52
@sberyozkin sberyozkin merged commit 09b1325 into quarkusio:main May 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 6, 2022
@gsmet gsmet modified the milestones: 2.10 - main, 2.9.1.Final May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.9.1.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aona42 @sberyozkin @gsmet