Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CONTRIBUTION regarding configuration properties generation #25316

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix CONTRIBUTION regarding configuration properties generation #25316

merged 1 commit into from
May 9, 2022

Conversation

michalvavrik
Copy link
Contributor

Fixes: #25315

@geoand geoand requested a review from gsmet May 3, 2022 05:57
gsmet
gsmet requested changes May 3, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Indeed it looks like it's not working.

I added a few suggestions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels May 4, 2022
@michalvavrik
Copy link
Contributor Author

@gsmet thank you for suggestions, I pushed changes

@michalvavrik michalvavrik requested a review from gsmet May 4, 2022 20:38
@gsmet gsmet merged commit 53e28d1 into quarkusio:main May 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 9, 2022
@gsmet
Copy link
Member

gsmet commented May 9, 2022

Thanks!

@michalvavrik michalvavrik deleted the fix-docs-contribution branch June 11, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.10.0.CR1
Development

Successfully merging this pull request may close these issues.

Explain how to generate config properties in 'How to contribute'
2 participants
@michalvavrik @gsmet