New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Diataxis framework templates #25354
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
b02c10d
to
f606126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a bunch of comments. Some are minor, some not so much.
@@ -0,0 +1,26 @@ | |||
// tag::application[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's such a good idea to have the sources like that.
We won't be able to compile them given the conventions you used so it's not really better than having them in the .adoc.
If we do that, we need to make _examples
an appropriate source directory and the content of it a proper thing with packages but...
Problem is that you will end up with a gigantic Quarkus app if all the sources are in the same module. And it probably won't work as some extensions cannot be combined with some others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can certainly make a proper src tree under examples if that's what we want to do. The comments alone are fine..
This is something I did want to ask. We could be annotating source from quickstarts (remote sources can still use tagged regions...), but I would like to see if we can get here somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, what I'm saying is that what you're suggesting here is not an improvement: it requires more work and is not compilable/compiled.
If you think you can make a proper src tree under examples, then let's demo it because my fear is that you won't be able to make it work properly without some really annoying work i.e. basically reconstructing the quickstarts here.
So my advice would be to get rid of this until we can find a proper solution. Or until you can show me what you did can work and will scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or we acccept that this is a one-off that demonstrates what should be done using source from a quickstart ... I'm not sure I want to create a new quickstart just for this docs example.
I can make it more clear this is a one-off example, and perform a similar markup to the micrometer quickstart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One option (aside from this one-off example) is to encourage source samples to come from integration tests..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long term, I think pulling from integration tests (which are compiled and run) is the right answer. A build-time fetch/copy of referenced source files for use in docs (in the same way we generate config files), but the build/test happens in the integration tests that have the correct dependency configurations.
This kind of code referencing is also optional, but I wanted to have an example of it.
docs/src/main/diataxis/_examples/acme-serve-http-requests-tutorial.adoctxt
Outdated
Show resolved
Hide resolved
510c16d
to
ba67e6c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7050c10
to
7566366
Compare
33caba8
to
c3a9760
Compare
7e3f3cd
to
5eb9578
Compare
b2b833c
to
7aafd82
Compare
|
||
=== Using a source file | ||
|
||
We are going to write the code for this tutorial in separate Java files, which brings us the benefit of syntax highlighting and an improved ability to ensure the code we're referencing makes sense as a whole. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a blurp stating including directly in adoc is ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
does not change or affect current layout and let us get moving on getting diataxis doc approach going and evolve to what goes into website/docs sites.
|
||
[source,shell] | ||
---- | ||
$ ./mvnw clean install -Dquickly \ #<1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebullient clean install
is the default goal for the profile quickly
, so maybe you could leave it out for taciturnity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #26664
The directory structure: diataxis vs asciidoc is temporary, to identify what has been touched and what hasn't. Consider it an internal detail (not surfaced on the website).
the
doc-\*
pages are intended for those that will be contributing to Quarkus documentation, so they understand the intent/distinction between the four types of docs. This content also provides exemplars of each type:doc-\*-tutorial.adoc
for tutorials,doc-\*-howto.adoc
for how-tos,doc-\*-concepts.adoc
for concepts, anddoc-\*-reference.adoc
for references.Resolves #25355
UPDATE:
asciidoc
directory so we can make incremental progress on improving docs. See Docs: generate index.yaml with title + preamble #25952 for a tool that will enumerate the docs that don't fit in any of the target categories or are missing required things so we know what still needs to be done.ADDITIONAL NOTES (2022-06-29):