Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry.adoc #25373

Merged
merged 2 commits into from
May 9, 2022
Merged

Update opentelemetry.adoc #25373

merged 2 commits into from
May 9, 2022

Conversation

manstis
Copy link
Contributor

@manstis manstis commented May 4, 2022

Following #25372 this documents the issue I encountered and offers a solution.

Feel free to reject.. it would have helped me save a few hours but that's more likely because I'm a newb in this area.

@@ -181,6 +181,7 @@ services:
depends_on:
- jaeger-all-in-one
----
If `jaeger-all-in-one` fails to start due to `'' has invalid keys: tls` try a fixed version, such as `0.41.0`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manstis I'm having a look at this but I'm not sure I understand. From what I can see this image is at version 1.33 so far beyond 0.41 and we use the latest.

What I miss is that if you had issues because you were specifying a version older than 0.41 or if newer versions specified with latest have problems?

Thanks!

Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it doesn't make sense to document specific version changes. If the current latest is not working with our configuration we just need to fix it.

manstis and others added 2 commits May 9, 2022 10:50
Following quarkusio#25372 this documents the issue I encountered and offers a solution.

Feel free to reject.. it would have helped me save a few hours but that's more likely because I'm a newb in this area.
@manstis
Copy link
Contributor Author

manstis commented May 9, 2022

@radcortez Done. Thank-you.

@radcortez
Copy link
Member

Thank you @manstis

@radcortez radcortez merged commit e24fec4 into quarkusio:main May 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants