Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Enum constant description in documentation #25375

Merged
merged 1 commit into from
May 11, 2022

Conversation

michalvavrik
Copy link
Contributor

Currently Enum constant Javadoc is not included in generated documentation. This PR adds a constant description to the documentation in a form of a CSS Tooltip (Tooltip was added by this PR). PDF generation won't be affected by this PR.

@machi1990
Copy link
Member

Thanks for adding this @michalvavrik

I'll have a look at it properly tomorrow. Is it possible to share an example generated output?

@machi1990 machi1990 self-assigned this May 5, 2022
@michalvavrik
Copy link
Contributor Author

@machi1990 I'd suggest to generate docs (mvn clean install -DskipTests -DskipITs -Denforcer.skip -DskipExtensionValidation -Dinvoker.skip -Dforbiddenapis.skip -DskipCodestartValidation) and look for tooltip: (grep -l 'tooltip:' target/ -R). You should find plenty of examples in quarkus-all-config.adoc. You can also see the result if you copy this file to generated-config/latest/config/quarkus-all-config.adoc prior to running bundle exec jekyll serve in quarkusio.github.io. This should give you bigger advantage than if I provided generated output. If I can help you in anyway, don't hesitate to contact me.

@machi1990
Copy link
Member

@machi1990 I'd suggest to generate docs (mvn clean install -DskipTests -DskipITs -Denforcer.skip -DskipExtensionValidation -Dinvoker.skip -Dforbiddenapis.skip -DskipCodestartValidation) and look for tooltip: (grep -l 'tooltip:' target/ -R). You should find plenty of examples in quarkus-all-config.adoc.

Thanks, I know this ;-)

You can also see the result if you copy this file to generated-config/latest/config/quarkus-all-config.adoc prior to running bundle exec jekyll serve in quarkusio.github.io. This should give you bigger advantage than if I provided generated output. If I can help you in anyway, don't hesitate to contact me.

I was asking more of a generated live output from this step which you seem to have already done end to end. So if you still have it, it'll be good to see it along side the PR description for better visualization.

/cc @gsmet you might also be interested in this PR

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I can see the tooltip being generated in the .ascidoc generated output.

However, I could not verify the whole rendering as I do not have the full toolset. @gsmet would you be able to verify this part and how it'll render on the website?

@michalvavrik
Copy link
Contributor Author

generated-live-output.zip
I see, let's try unzip this file and open Quarkus - All configuration options.html (the rest of files are required in order to display page correctly).

@machi1990
Copy link
Member

generated-live-output.zip I see, let's try unzip this file and open Quarkus - All configuration options.html (the rest of files are required in order to display page correctly).

Thanks @michalvavrik, fantastic work. The tooltip renders nicely.

@geoand geoand merged commit 7e770db into quarkusio:main May 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 11, 2022
@michalvavrik michalvavrik deleted the feature/docs-missing-enum-desc branch May 11, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants