New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger restart when deleting previously existing watched file #25376
Conversation
This comment has been minimized.
This comment has been minimized.
Will have to take a closer look why the maven tests failed, looks related. |
Setting to draft, I want to do a full CI run in my fork first. I also need to possible do a bit more cleanup before this is ready. I found the reason why the tests where failing. Basicly, it went like this. First, resource-dir-a was checked. application.properties was found - no need to delete anything. |
b27f048
to
295e57c
Compare
CI passes in my fork, this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Postremus, thanks! Would be good to have a test for it though. Will you have time to add one? Just in case it helps, we already have some test projects that include extensions, e.g. https://github.com/quarkusio/quarkus/tree/main/integration-tests/maven/src/test/resources-filtered/projects/project-with-extension.
Also fixes naming of the processor responsible for the initial watched files scan
@aloubyansky I added one in DevMojoIT. |
Excellent. Thanks @Postremus ! |
Also fixes naming of the processor responsible for the initial watched files scan
Fixes #25331