Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve standalone codestart testing #25397

Merged

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented May 5, 2022

Fixes #25043

cc @evacchi with this you don't need to set the version anymore:

ex:

@RegisterExtension
    public static QuarkusCodestartTest codestartTest = QuarkusCodestartTest.builder()
            .setupStandaloneExtensionTest("io.quarkiverse.quinoa:quarkus-quinoa")
            .languages(JAVA)
            .build();

@ia3andy ia3andy requested a review from aloubyansky May 5, 2022 12:00
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels May 5, 2022
@ia3andy ia3andy force-pushed the improve-standalone-codestart-testing branch from 8989817 to 0162e9d Compare May 5, 2022 12:03
@quarkus-bot

This comment has been minimized.

@evacchi
Copy link
Contributor

evacchi commented May 5, 2022

@tarilabs FYI

@tarilabs
Copy link
Contributor

tarilabs commented May 5, 2022

@evacchi I assume you are referring to these 3 lines: https://github.com/kiegroup/kogito-runtimes/blob/56bec5e4d4511087d0de3a9a531aeb9d21621139/quarkus/extensions/kogito-quarkus-decisions-extension/kogito-quarkus-decisions-integration-test/src/test/java/org/kie/kogito/quarkus/dmn/KogitoDMNCodeCodestartIT.java#L52-L54

@ia3andy once this is merged and available in a Quarkus version, all those 3 lines can be replaces with a string of GA such as groupId:artifactId, am I understanding the expectation impact on extension codestart developed correctly, please?

@evacchi
Copy link
Contributor

evacchi commented May 5, 2022

yep @tarilabs :)

@ia3andy ia3andy force-pushed the improve-standalone-codestart-testing branch from 0162e9d to c316525 Compare May 6, 2022 07:59
@ia3andy
Copy link
Contributor Author

ia3andy commented May 9, 2022

@aloubyansky this one is waiting for your blessing :)

@ia3andy ia3andy force-pushed the improve-standalone-codestart-testing branch from c316525 to 728ae70 Compare May 10, 2022 12:51
@ia3andy ia3andy requested a review from aloubyansky May 10, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new extension codestart loading system in QuarkusCodestartTest
4 participants