Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EmptyBuildItem handling and add a note on how to use them #25483

Merged
merged 1 commit into from
May 11, 2022
Merged

Improve EmptyBuildItem handling and add a note on how to use them #25483

merged 1 commit into from
May 11, 2022

Conversation

loicmathieu
Copy link
Contributor

No description provided.

gsmet
gsmet previously requested changes May 10, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo. I will let others check the rest :).

docs/src/main/asciidoc/writing-extensions.adoc Outdated Show resolved Hide resolved
@loicmathieu
Copy link
Contributor Author

Thanks @gsmet, Georgios works with me on this one ;)

@loicmathieu loicmathieu marked this pull request as ready for review May 10, 2022 14:05
@loicmathieu loicmathieu requested a review from geoand May 10, 2022 14:05
geoand
geoand approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand dismissed gsmet’s stale review May 11, 2022 05:49

comment addressed

@geoand geoand merged commit cc5e528 into quarkusio:main May 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 11, 2022
@loicmathieu loicmathieu deleted the improve-empty-builditem branch May 20, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
area/core area/documentation
Projects
None yet
Milestone
2.10.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loicmathieu @gsmet @geoand