Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oidc Client and Token Propagation Quickstart #25507

Merged
merged 1 commit into from
May 24, 2022

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented May 11, 2022

This PR creates a security-openid-connect-client-quickstart.adoc which is separate from security-openid-connect-client.adoc which is effectively a reference guide. These 2 docs link to each other, from the quickstart a user can move to a reference guide and vice versa

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we keep things consistent. For all the others, the reference guide is the one suffixed (with -reference).

@sberyozkin
Copy link
Member Author

@gsmet Have a look please if it is better now

@@ -0,0 +1,506 @@
////
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I wasn't clear but this one shouldn't have the -quickstart suffix. And the links to it should be updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet I see, got it, renamed it

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a link that was still incorrect. Let's wait for CI.

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed triage/backport? labels May 24, 2022
@gsmet
Copy link
Member

gsmet commented May 24, 2022

Also, I don't think we should backport this as it adds new guides and changes the content of some entirely.

@geoand geoand merged commit 28393fc into quarkusio:main May 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 24, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants