-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Oidc Client and Token Propagation Quickstart #25507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we keep things consistent. For all the others, the reference guide is the one suffixed (with -reference).
185b070
to
20b4b01
Compare
@gsmet Have a look please if it is better now |
@@ -0,0 +1,506 @@ | |||
//// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I wasn't clear but this one shouldn't have the -quickstart
suffix. And the links to it should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet I see, got it, renamed it
20b4b01
to
64a85e7
Compare
64a85e7
to
e2ff972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a link that was still incorrect. Let's wait for CI.
Also, I don't think we should backport this as it adds new guides and changes the content of some entirely. |
This PR creates a
security-openid-connect-client-quickstart.adoc
which is separate fromsecurity-openid-connect-client.adoc
which is effectively a reference guide. These 2 docs link to each other, from the quickstart a user can move to a reference guide and vice versa