Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in doc for using Kotlin with older versions of Mandrel #25508

Merged
merged 1 commit into from May 12, 2022

Conversation

mihaipoenaru
Copy link

To avoid crashes like the one described in #25460, I've added a small warning label right at the start of the guide.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I amended your commit to improve the wording a bit.
Also we avoid referencing titles without a proper anchor as it's a bit brittle and can easily get broken when we adjust at title.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 12, 2022
@mihaipoenaru
Copy link
Author

Thanks, @gsmet ! I haven't worked with asciidoc before so I didn't know you could do that.

@gsmet gsmet merged commit 9e259a1 into quarkusio:main May 12, 2022
@gsmet
Copy link
Member

gsmet commented May 12, 2022

Merged, thanks!

@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 12, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 12, 2022
@gsmet gsmet modified the milestones: 2.10 - main, 2.9.1.Final May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants