Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document optional declaration of io.quarkus.qute.i18n.Message.value() #25518

Merged

Conversation

michalvavrik
Copy link
Contributor

Documents: #17857

@michalvavrik
Copy link
Contributor Author

cc @mkouba

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added some minor comments...

docs/src/main/asciidoc/qute-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/qute-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/qute-reference.adoc Outdated Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/doc-qute-optinal-message branch from 14da2a1 to 3fb2ceb Compare May 12, 2022 09:14
@michalvavrik
Copy link
Contributor Author

michalvavrik commented May 12, 2022

Fixed, thank you for the feedback.

@michalvavrik michalvavrik requested a review from mkouba May 12, 2022 09:15
@mkouba mkouba added this to the 2.10 - main milestone May 12, 2022
@mkouba mkouba merged commit 3f9bf7b into quarkusio:main May 12, 2022
@mkouba
Copy link
Contributor

mkouba commented May 12, 2022

Merged, thanks!

@michalvavrik michalvavrik deleted the feature/doc-qute-optinal-message branch May 12, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants