Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Keycloak server version to 18 #25524

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

pedroigor
Copy link
Contributor

Closes #25109

@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member

@pedroigor Thanks, let me look at it and align with #25109

@sberyozkin
Copy link
Member

@pedroigor I've aligned it with #25109. The extension tests are duplicated by the ones in integration-tests, thanks for removing them, it would be too messy to support such migrations twice in the Quarkus code and it will slow down the builds. I'll do a check soon to make sure no extension specific tests are lost - will move them to the integration-tests/keycloak-authorization if I find something specific to the extensions

@sberyozkin sberyozkin marked this pull request as draft May 12, 2022 14:33
@sberyozkin
Copy link
Member

@pedroigor keycloak-authorization integration tests are green, thanks :-), going to review the extension tests to avoid losing something

@sberyozkin sberyozkin marked this pull request as ready for review May 12, 2022 16:41
@sberyozkin
Copy link
Member

extension/keycloak-authorization/deployment contains a limited subset compared to integration-tests/keycloak-authorization

@sberyozkin
Copy link
Member

sberyozkin commented May 12, 2022

@pedroigor But before merging, lets have quarkus-quickstarts/keycloak-authorization updated as well.
There are 2 problems there, 1) Policies are already in quarkus-realm.json and the policies need to be updated somehow in that .json - we probably also need to add a policy scripts jar as a resource there 2) DevServices for Keycloak is used to test, so I will need to add some extra config to Keycloak DevServicesConfig and copy the library jar

Can you please look at 1) when you can and open a PR in quickstarts ? And I will do 2), I think I will need to push 2)-related changes as part of this PR

@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member

Hey @pedroigor Thanks for checking the quickstarts, I was wrong that keycloak-authorization was using JS policies.
All is good now, let me merge, major thanks for your help

@sberyozkin sberyozkin merged commit 958328b into quarkusio:main May 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 16, 2022
@sberyozkin
Copy link
Member

I'll update the migration guide today

@sberyozkin
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/keycloak area/keycloak-authorization area/oidc kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants