Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to LocalProject data if Maven does not provide metadata in quarkus:dev #2554

Merged
merged 3 commits into from May 22, 2019
Merged

Fallback to LocalProject data if Maven does not provide metadata in quarkus:dev #2554

merged 3 commits into from May 22, 2019

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented May 22, 2019 •
edited

(closes #2549)

this PR skips the submodule if the MavenProject does not provide metadata about that submodule. This is a significant change from previous versions, where Quarkus tried to infer something from the POM, but it's also more consistent with the way the Maven build works

@evacchi evacchi changed the title NullPointerException in DevMojo when running mvn compile quarkus:dev Ignore submodule if Maven does not provide metadata May 22, 2019
@evacchi evacchi changed the title Ignore submodule if Maven does not provide metadata Ignore submodule if Maven does not provide metadata in quarkus:dev May 22, 2019
@gastaldi
Copy link
Contributor

I can confirm that this PR fixes #2549

@aloubyansky aloubyansky self-requested a review May 22, 2019 14:10
@aloubyansky
Copy link
Member

This change will break multimodule dev-mode support in a different way. So it's not a fix.
A quick fix would be to fallback to the LocalProject in case the corresponding MavenProject isn't available. It means that some of the dependencies that include multiple sources dirs will be monitored for changes only in the "main" java sources dir and the rest of the sources dirs will be ignored.

This means that multiple sources dirs are still not properly supported in dev mode. That's not a regression though, unlike if simply ignore a dependency as suggested in this PR.

@aloubyansky aloubyansky mentioned this pull request May 22, 2019
Merged
aloubyansky
aloubyansky approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the CI. Thanks for your contribution!

@aloubyansky aloubyansky added this to the 0.16.0 milestone May 22, 2019
@aloubyansky aloubyansky added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2019
@aloubyansky aloubyansky changed the title Ignore submodule if Maven does not provide metadata in quarkus:dev Fallback to LocalProject data if Maven does not provide metadata in quarkus:dev May 22, 2019
@kenfinnigan kenfinnigan removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2019
@kenfinnigan kenfinnigan merged commit 903dea1 into quarkusio:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

NullPointerException in DevMojo when running mvn compile quarkus:dev
4 participants
@evacchi @gastaldi @aloubyansky @kenfinnigan