Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order for hal extension #25548

Merged
merged 1 commit into from
May 13, 2022
Merged

Change order for hal extension #25548

merged 1 commit into from
May 13, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario
Copy link
Contributor Author

@geoand I haven't been able to reproduce the CI error in my local machine, do you have any tips to confirm that this pull request will fix the CI failures?

1 similar comment
@Sgitario
Copy link
Contributor Author

@geoand I haven't been able to reproduce the CI error in my local machine, do you have any tips to confirm that this pull request will fix the CI failures?

@geoand
Copy link
Contributor

geoand commented May 13, 2022

I would wipe out my local.m2/repository directory and try.

There is likely some leftover that causes the build to pass on your machine

@Sgitario
Copy link
Contributor Author

But it also passes in the CI for pull requests :/

@geoand
Copy link
Contributor

geoand commented May 13, 2022

But it also passes in the CI for pull requests :/

Yeah... Not sure what's going on there

@Sgitario
Copy link
Contributor Author

But it also passes in the CI for pull requests :/

Yeah... Not sure what's going on there

I still could not reproduce the error even after having removed my maven repository.
Anyway, I think this PR should fix it.

@geoand geoand merged commit 5b0d3a4 into quarkusio:main May 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 13, 2022
@Sgitario Sgitario deleted the fix_deploy2 branch May 13, 2022 10:42
@gsmet
Copy link
Member

gsmet commented May 13, 2022

There's very little chance this is the right fix. The build should be constrained by dependencies, not by the order in the pom file. It will especially go wrong with any sort of parallel build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants