New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes docs: Replace static tables with the auto-generated tables #25617
Conversation
Not sure if we should delete the openshift part taking into account we have a separated guide for OpenShift: https://quarkus.io/guides/deploying-to-openshift And perhaps we should move the knative part into a new guide too. |
@iocanel could you have a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+100 on the idea. However, it's not clear to me who generates those files. I've seen in the past some related jbang scripts which seemed to convert Config object to adoc files. Do I remember correctly?
I found out that some properties were not synced between the content in the Kubernetes guide and the config-all page (which uses the auto generated table). Let's use the auto-generated tables also in the Kubernetes guide, so we avoid having to maintain these properties, plus also having to explain the inner basic types (as it's already part of the auto generated table).
e9b8a8a
to
e385b37
Compare
I'm unsure which tool is generating the adoc files from Config objects, but it's working fine so far. |
Ok, I'll take your word for it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I found out that some properties were not synced between the content in the Kubernetes guide and the config-all page (which uses the auto generated table).
Let's use the auto-generated tables also in the Kubernetes guide, so we avoid having to maintain these properties, plus also having to explain the inner basic types (as it's already part of the auto generated table).