Improve error message for Reactive Messaging coroutine support #25654
Conversation
| @@ -13,7 +13,7 @@ abstract class AbstractSubscribingCoroutineInvoker(private val beanInstance: Any | |||
| override fun invoke(vararg args: Any?): CompletableFuture<Any?> { | |||
| val coroutineScope = Arc.container().instance(ApplicationCoroutineScope::class.java).get() | |||
| val dispatcher: CoroutineDispatcher = Vertx.currentContext()?.let(::VertxDispatcher) | |||
| ?: throw IllegalStateException("No Vertx context found") | |||
| ?: throw IllegalStateException("No Vertx context found. Consider using @NonBlocking on the suspend method.") | |||
There was a problem hiding this comment.
This change needs to be on io.quarkus.scheduler.kotlin.runtime.AbstractCoroutineInvoker
For reactive messaging, this is an edge case, I propose No Vertx context found. Consider emitting items on Vert.x context.
There was a problem hiding this comment.
Ah, you are right, wrong class!
There was a problem hiding this comment.
Actually... the error is coming from AbstractSubscribingCoroutineInvoker, not io.quarkus.scheduler.kotlin.runtime.AbstractCoroutineInvoker
There was a problem hiding this comment.
In any case, error message updated.
FWIW, this error should never happen for the scheduler, as suspend methods are always executed on a vert.x thread
There was a problem hiding this comment.
Oh, ok I'd missed that. That's because there is an emitter used inside, which itself ends up calling an incoming method with suspend... But @NonBlocking won't solve anything on the case with Mutiny tick.
Shall we write something generic along :
"Consider using @NonBlocking on the caller method, or make sure the upstream emits items on the Vert.x context".
Relates to: #25502