New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the custom Class-Path in the manifest file #25698
Conversation
PTAL @geoand |
I don't think this is going to work for fast-jar to be honest... |
Thanks, could you please explain it in detail? In my case, the app.jar and resources are separated into the same directory because they are often changed independently: .
├── app.jar
└── resources
├── application.properties
├── init
│ └── my.json
├── static
└── templates I need to load a resource by its name, for example using the method quarkus.package.manifest.attributes."Class-Path"=resources/ Use Thread.currentThread().getContextClassLoader().getResourceAsStream("init/my.json"); Why must the Class-Path of uber-jar be overwritten with blank when generating manifest? |
My comment was about fast-jar, not uber-jar :) |
Failing Jobs - Building b4d132e
Full information is available in the Build summary check run. Failures⚙️ Devtools Tests - JDK 11 #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
⚙️ Devtools Tests - JDK 17 #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
|
I'm not sure this really makes sense, especially with the closed world assumption we have in Quarkus. We want jars to be detectable by Quarkus and not pushed to it via the classpath. What is your requirement exactly and why do you want to do that, rather than say add a new dependency to your build file? |
Closing for lack of feedback. |
Currently we can specify custom manifest entries, but we cannot keep the custom
Class-Path
because generating the manifest would overwrite this existing entry.By adding additional JAR files and directories to the class path, we can not only avoid specifying a long
-classpath
flag, but also load resources via relative paths.