New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC - fix io.quarkus.arc.All List injection #25784
Conversation
- fix a case where `@All List<Foo>` and `@Inject @ALL List<Foo>` injection points are present - the value of a synthetic Identified qualifier is a hash of the type and all annotations, however, we do not add a synthetic bean if the type and qualifiers match; as a result of the injection points is not satisfied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
@mkouba Hmmm. I think it's the first time I see this failure. |
I have no idea what this assertion does but I can't see how this could be related to |
I don't. Maybe it was a hiccup on the OTel side, where the span order is changed somehow and it failed the asserts. I don't think the PR change is related to the failure. Let's see what the new build tells us. |
Failing Jobs - Building aef002a
Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/elasticsearch-rest-client integration-tests/hibernate-search-orm-elasticsearch-coordination-outbox-polling
📦 integration-tests/elasticsearch-rest-client✖ 📦 integration-tests/hibernate-search-orm-elasticsearch-coordination-outbox-polling✖ |
Test dependency injection using ArC `@All` with `List`. See also quarkusio/quarkus#25784.
Test dependency injection using ArC `@All` with `List`. See also quarkusio/quarkus#25784.
Test dependency injection using ArC `@All` with `List`. See also quarkusio/quarkus#25784.
Test dependency injection using ArC `@All` with `List`. See also quarkusio/quarkus#25784. (cherry picked from commit ad4f60e)
@All List<Foo>
and@Inject @All List<Foo>
injection points are presentand all annotations, however, we do not add a synthetic bean if the type and
qualifiers match; as a result of the injection points is not satisfied