Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC - fix io.quarkus.arc.All List injection #25784

Merged
merged 1 commit into from May 27, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 25, 2022

  • fix a case where @All List<Foo> and @Inject @All List<Foo> injection points are present
  • the value of a synthetic Identified qualifier is a hash of the type
    and all annotations, however, we do not add a synthetic bean if the type and
    qualifiers match; as a result of the injection points is not satisfied

- fix a case where `@All List<Foo>` and `@Inject @ALL List<Foo>` injection points are present
- the value of a synthetic Identified qualifier is a hash of the type
and all annotations, however, we do not add a synthetic bean if the type and
qualifiers match; as a result of the injection points is not satisfied
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 25, 2022
@mkouba mkouba added this to the 2.10 - main milestone May 25, 2022
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 25, 2022
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented May 25, 2022

@mkouba Hmmm. I think it's the first time I see this failure.

@mkouba
Copy link
Contributor Author

mkouba commented May 26, 2022

@mkouba Hmmm. I think it's the first time I see this failure.

I have no idea what this assertion does but I can't see how this could be related to @Inject @All List<>. @radcortez do you happen to use @Inject @All List<> somewhere around?

@gsmet gsmet changed the title ArC - fix io.quarku.arc.All List injection ArC - fix io.quarkus.arc.All List injection May 26, 2022
@radcortez
Copy link
Member

@mkouba Hmmm. I think it's the first time I see this failure.

I have no idea what this assertion does but I can't see how this could be related to @Inject @All List<>. @radcortez do you happen to use @Inject @All List<> somewhere around?

I don't. Maybe it was a hiccup on the OTel side, where the span order is changed somehow and it failed the asserts. I don't think the PR change is related to the failure. Let's see what the new build tells us.

@quarkus-bot
Copy link

quarkus-bot bot commented May 26, 2022

Failing Jobs - Building aef002a

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/elasticsearch-rest-client integration-tests/hibernate-search-orm-elasticsearch-coordination-outbox-polling 

📦 integration-tests/elasticsearch-rest-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.39.1:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-client: I/O Error

📦 integration-tests/hibernate-search-orm-elasticsearch-coordination-outbox-polling

Failed to execute goal io.fabric8:docker-maven-plugin:0.39.1:start (docker-start) on project quarkus-integration-test-hibernate-search-orm-elasticsearch-coordination-outbox-polling: I/O Error

@gsmet gsmet merged commit dbba916 into quarkusio:main May 27, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 27, 2022
@gsmet gsmet modified the milestones: 2.10 - main, 2.7.6.Final May 28, 2022
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this pull request Jun 8, 2022
Test dependency injection using ArC `@All` with `List`.
See also quarkusio/quarkus#25784.
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this pull request Jun 8, 2022
Test dependency injection using ArC `@All` with `List`.
See also quarkusio/quarkus#25784.
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this pull request Jun 8, 2022
Test dependency injection using ArC `@All` with `List`.
See also quarkusio/quarkus#25784.
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jun 10, 2022
Test dependency injection using ArC `@All` with `List`.
See also quarkusio/quarkus#25784.

(cherry picked from commit ad4f60e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants