Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registers media type text/xml for RESTEasy Reactive with JAXB #25888

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Registers media type text/xml for RESTEasy Reactive with JAXB #25888

merged 1 commit into from
Jun 1, 2022

Conversation

wjglerum
Copy link
Contributor

@wjglerum wjglerum commented May 31, 2022 •
edited

Fixes #25884 by adding the JAXB message body writers and readers for text/xml. Will still default to application/xml if unspecified for the message body writer.

Let me know if I should add this somewhere else too or provide some more (integration) tests.

@wjglerum wjglerum marked this pull request as ready for review May 31, 2022 15:20
@wjglerum wjglerum changed the title Registers media type text/xml for RESTEasy Reactive with JAXB Registers media type text/xml for RESTEasy Reactive with JAXB May 31, 2022
@wjglerum wjglerum force-pushed the resteasy-reactive-text-xml branch 2 times, most recently from 263b302 to 3f8d8bb Compare May 31, 2022 15:54
gastaldi
gastaldi approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi requested a review from geoand May 31, 2022 17:12
@geoand
Copy link
Contributor

geoand commented Jun 1, 2022

LGTM, @Sgitario do you agree as well?

Sgitario
Sgitario requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with registering the media type text/xml too.
There is one missing place where it should be added as well:

Plus, a minor suggestion too.

...java/io/quarkus/resteasy/reactive/jaxb/common/runtime/serialisers/JaxbMessageBodyReader.java Outdated Show resolved Hide resolved
@wjglerum wjglerum force-pushed the resteasy-reactive-text-xml branch from 3f8d8bb to 15713a9 Compare June 1, 2022 08:38
@quarkus-bot quarkus-bot bot added the area/hibernate-validator Hibernate Validator label Jun 1, 2022
@wjglerum wjglerum force-pushed the resteasy-reactive-text-xml branch from 15713a9 to d3b3623 Compare June 1, 2022 09:03
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 1, 2022
@gastaldi gastaldi merged commit 211a5a0 into quarkusio:main Jun 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone Jun 1, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 1, 2022
@wjglerum wjglerum deleted the resteasy-reactive-text-xml branch June 1, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

@gastaldi gastaldi gastaldi approved these changes

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/hibernate-validator Hibernate Validator area/resteasy-reactive kind/bugfix
Projects
None yet
Milestone
2.10.0.CR1
Development

Successfully merging this pull request may close these issues.

Media type text/xml not working with REST Client Reactive
5 participants
@wjglerum @geoand @gastaldi @Sgitario @gsmet