Introduce gRPC post-processing #26041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
cescoffier
force-pushed
the
grpc-post-processing
branch
from
6d9bd63
to
4e33ed6
Compare
gsmet
reviewed
Jun 10, 2022
extensions/grpc-common/runtime/src/main/java/io/quarkus/grpc/common/runtime/Generated.java
Outdated
Show resolved
Hide resolved
|
Very neat! |
When using gRPC, there is a code generation phase. The generator (protoc) generates a bunch of classes used to implement and consume the services. This commit introduces a post-processing phase to that generation so we can modify the generated source files. The rationale is twofold: 1. stubs cannot be mocked because of the `final` modifier in the source. 2. the generated classes use `javax.annotation.Generated`, which blocks the migration to Jakarta. The current post-processing addresses these two issues. Each feature can be disabled individually. The whole post-processing can also be disabled.
cescoffier
force-pushed
the
grpc-post-processing
branch
from
4e33ed6
to
9c68d21
Compare
Failing Jobs - Building 9c68d21
Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/elasticsearch-rest-client
📦 integration-tests/elasticsearch-rest-client✖ |
|
The failure looks unrelated. |
|
Indeed |
gsmet
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using gRPC, there is a code generation phase. The generator (protoc) generates a bunch of classes used to implement and consume the services.
This commit introduces a post-processing phase to that generation so we can modify the generated source files.
The rationale is twofold:
finalmodifier in the source.javax.annotation.Generated, which blocks the migration to Jakarta.The current post-processing addresses these two issues. Each feature can be disabled individually. The whole post-processing can also be disabled.