Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RESTEasy Reactive path matching more spec compliant #26101

Merged
merged 1 commit into from Jun 14, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 14, 2022

RESTEasy Classic already behaves properly, so we should follow this patterns

Fixes: #26016

@quarkus-bot

This comment has been minimized.

RESTEasy Classic already behaves properly, so we should follow this patterns

Fixes: quarkusio#26016
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Though this change should be listed in the release notes.

@geoand
Copy link
Contributor Author

geoand commented Jun 14, 2022

Definitely. That's why I added the breaking-change label.

@geoand
Copy link
Contributor Author

geoand commented Jun 14, 2022

@gsmet how do you feel about getting this into 2.10? I am kind of -0.5...

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 14, 2022

Failing Jobs - Building 36e95a0

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

@geoand geoand requested a review from gastaldi June 14, 2022 10:20
@gastaldi gastaldi merged commit 9a24d12 into quarkusio:main Jun 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 14, 2022
@gastaldi gastaldi deleted the #26016 branch June 14, 2022 10:48
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 16, 2022
Tests fails as path called by Rest Client is not found. IMHO that's due to [this PR](quarkusio/quarkus#26101). One way or another, adjusting resource/client paths fixes the issue.
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 16, 2022
Tests fails as path called by Rest Client is not found. IMHO that's due to [this PR](quarkusio/quarkus#26101). One way or another, adjusting resource/client paths fixes the issue.
refactor
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 16, 2022
Tests fails as path called by Rest Client is not found. IMHO that's due to [this PR](quarkusio/quarkus#26101). One way or another, adjusting resource/client paths fixes the issue.
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 16, 2022
Tests fails as path called by Rest Client is not found. IMHO that's due to [this PR](quarkusio/quarkus#26101). One way or another, adjusting resource/client paths fixes the issue.
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 16, 2022
Tests fails as path called by Rest Client is not found. IMHO that's due to [this PR](quarkusio/quarkus#26101). One way or another, adjusting resource/client paths fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants