Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GraphQL endpoints to be Singleton by default #26105

Merged
merged 1 commit into from Jun 14, 2022
Merged

Change GraphQL endpoints to be Singleton by default #26105

merged 1 commit into from Jun 14, 2022

Conversation

jmartisk
Copy link
Contributor

Fixes #26103

phillip-kruger
phillip-kruger approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 14, 2022

Failing Jobs - Building 0677a00

Status Name Step Failures Logs Raw logs
⌛ Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
⌛ Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@jmartisk jmartisk merged commit bdf44dd into quarkusio:main Jun 14, 2022
@jmartisk jmartisk deleted the main-issue-26103 branch June 14, 2022 10:15
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 14, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 14, 2022
@gsmet
Copy link
Member

gsmet commented Jun 21, 2022

Could you add an entry to the migration guide for 2.11: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.11 ?

Thanks!

@phillip-kruger
Copy link
Member

@jmartisk ^^^

@jmartisk
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
area/graphql area/smallrye kind/enhancement New feature or request release/breaking-change release/noteworthy-feature
Projects
None yet
Milestone
2.11.0.CR1
Development

Successfully merging this pull request may close these issues.

Change GraphQL endpoints to be @Singleton by default
4 participants
@jmartisk @gsmet @phillip-kruger @geoand