Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust project gen template to use extension plugin artifactId depending on Quarkus version #26130

Merged

Conversation

aloubyansky
Copy link
Member

Fix #26014

@ia3andy could you please check whether that's an acceptable way of fixing it? Thanks.

To check the effects of this change, the legacy plugin should currently be used when a project is generated with

quarkus create extension

and the new plugin should be used when a project is generated with

quarkus create extension -S 2.10

@aloubyansky aloubyansky requested a review from ia3andy June 14, 2022 16:49
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 14, 2022
@quarkus-bot

This comment has been minimized.

@aloubyansky aloubyansky force-pushed the extension-plugin-version-template branch from 7cca7b4 to 58a321b Compare June 15, 2022 07:37
@ia3andy
Copy link
Contributor

ia3andy commented Jun 15, 2022

Looking..

@aloubyansky aloubyansky force-pushed the extension-plugin-version-template branch from 8d84dc7 to 5ad8e26 Compare June 15, 2022 12:51
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@ia3andy ia3andy added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 15, 2022
@aloubyansky aloubyansky merged commit d58895b into quarkusio:main Jun 15, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 15, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 15, 2022
rsvoboda added a commit to rsvoboda/quarkus-test-suite that referenced this pull request Jun 16, 2022
…ream"

This reverts commit fb912d2.

Fixed in quarkusio/quarkus#26130, we do not need to wait for Quarkus 2.10 release
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.1.Final Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom extension is looking for missing quarkus-extension-maven-plugin:JAR:2.9.2.Final
3 participants