Fix package structure in Hibernate Search extension and integration tests #26147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d package Just to avoid split packages, since we'll add some code into the root package for this extension, but in the runtime module.
This comment has been minimized.
This comment has been minimized.
gsmet
approved these changes
Jun 15, 2022
yrodiere
force-pushed
the
i24922-search-extension
branch
from
1562236
to
2462f18
Compare
|
Right, sorry. Done. |
gsmet
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
yrodiere
force-pushed
the
i24922-search-extension
branch
from
2462f18
to
67a7ca5
Compare
quarkus-bot
bot
removed
the
triage/waiting-for-ci
yrodiere
added a commit
to yrodiere/quarkus-hibernate-search-extras
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the first commit in particular, before I can introduce public API in order to address #24922.
The other commits are not strictly necessary but IMO a nice cleanup.