Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Gradle dependency cache to speed up CI #26194

Merged
merged 1 commit into from Jun 19, 2022

Conversation

glefloch
Copy link
Member

This leverage github action to cache gradle dependencies and downloading everything on each run

@glefloch glefloch requested a review from famod June 16, 2022 19:36
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jun 16, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea. I added a small suggestion inline. I wouldn't do that for the existing cache now but we could experiment with this for the newly added one.

with:
path: ~/.gradle/caches
# refresh cache every month to avoid unlimited growth
key: q2gradle-${{ steps.get-date.outputs.date }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea but maybe we could try to use the cache feature integrated in setup-java@v3? More details here: https://github.com/actions/setup-java#caching-packages-dependencies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the branch using the setup-java@v3

@famod
Copy link
Member

famod commented Jun 16, 2022

Gradle is also running in the initial build, no? Might be beneficial there as well. But I guess the keys should be different then because I guess the gradle run in the initial build pulls in fewer dependencies than in the test job?

@famod
Copy link
Member

famod commented Jun 16, 2022

This is what I mean, from the initial build:

2022-06-16T19:51:05.3507692Z [INFO] Quarkus - Maven Plugin ............................. SUCCESS [  7.282 s]
2022-06-16T19:51:05.3508108Z [INFO] Quarkus - Gradle Plugin - Parent ................... SUCCESS [  0.047 s]
2022-06-16T19:51:05.3508595Z [INFO] Quarkus - Gradle Model ............................. SUCCESS [01:22 min]
2022-06-16T19:51:05.3509018Z [INFO] Quarkus - Gradle Plugin ............................ SUCCESS [ 39.042 s]
2022-06-16T19:51:05.3509448Z [INFO] Quarkus - Extension Gradle Plugin .................. SUCCESS [ 37.329 s]
2022-06-16T19:51:05.3509886Z [INFO] Quarkus - Command Line Interface ................... SUCCESS [ 10.434 s]
2022-06-16T19:51:05.3510315Z [INFO] Quarkus - Integration Tests ........................ SUCCESS [  0.053 s]

@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try that and see how it goes.

@gsmet
Copy link
Member

gsmet commented Jun 18, 2022

I rebased to drop the merge commit btw.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 18, 2022

Failing Jobs - Building a944859

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment 

📦 extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment

io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest.shouldConsumePlainXMLEntity - More details - Source on GitHub

org.jboss.resteasy.reactive.ClientWebApplicationException: Received: 'Internal Server Error, status code 500' when invoking: Rest Client method: 'io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest$XmlClient#plain'
	at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.unwrapException(RestClientRequestContext.java:170)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.handleException(AbstractResteasyReactiveContext.java:317)

io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest.shouldConsumeXMLEntity - More details - Source on GitHub

org.jboss.resteasy.reactive.ClientWebApplicationException: Received: 'Internal Server Error, status code 500' when invoking: Rest Client method: 'io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest$XmlClient#dto'
	at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.unwrapException(RestClientRequestContext.java:170)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.handleException(AbstractResteasyReactiveContext.java:317)

@glefloch
Copy link
Member Author

Thanks, I missed it.

@glefloch
Copy link
Member Author

I don't think failure is related, right ?

@famod
Copy link
Member

famod commented Jun 18, 2022

I don't think so. That test failed in another PR of mine in a similar way.

@glefloch glefloch merged commit c07a764 into quarkusio:main Jun 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 19, 2022
@glefloch glefloch deleted the fix/gradle-cache branch June 19, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants