New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache Gradle dependency cache to speed up CI #26194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool idea. I added a small suggestion inline. I wouldn't do that for the existing cache now but we could experiment with this for the newly added one.
with: | ||
path: ~/.gradle/caches | ||
# refresh cache every month to avoid unlimited growth | ||
key: q2gradle-${{ steps.get-date.outputs.date }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea but maybe we could try to use the cache feature integrated in setup-java@v3
? More details here: https://github.com/actions/setup-java#caching-packages-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the branch using the setup-java@v3
Gradle is also running in the initial build, no? Might be beneficial there as well. But I guess the keys should be different then because I guess the gradle run in the initial build pulls in fewer dependencies than in the test job? |
This is what I mean, from the initial build:
|
This comment has been minimized.
This comment has been minimized.
72600ea
to
caa7e95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try that and see how it goes.
I rebased to drop the merge commit btw. |
Failing Jobs - Building a944859
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment
📦 extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment✖
✖
|
Thanks, I missed it. |
I don't think failure is related, right ? |
I don't think so. That test failed in another PR of mine in a similar way. |
This leverage github action to cache gradle dependencies and downloading everything on each run