Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE with OTel when wrong HTTP protocol version is sent #26313

Merged
merged 1 commit into from Jun 27, 2022
Merged

NPE with OTel when wrong HTTP protocol version is sent #26313

merged 1 commit into from Jun 27, 2022

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Jun 23, 2022 •
edited

Fix for #26149

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 23, 2022

/cc @radcortez

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 23, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@brunobat brunobat changed the title Fix #26149 - NPE with OTel NPE with OTel when wrong HTTP protocol version is sent Jun 23, 2022
gsmet
gsmet reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of (naive) comments.

For bugfixes that we want to backport, please also add the triage/backport? label so that we include it in the next backport train.

...ion-tests/opentelemetry/src/test/java/io/quarkus/it/opentelemetry/OpenTelemetryTestCase.java Outdated Show resolved Hide resolved
...ion-tests/opentelemetry/src/test/java/io/quarkus/it/opentelemetry/OpenTelemetryTestCase.java Outdated Show resolved Hide resolved
...rc/main/java/io/quarkus/opentelemetry/runtime/tracing/vertx/HttpInstrumenterVertxTracer.java Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

Sign in to view
@radcortez
Copy link
Member

Remember to build the changed code to apply the formatter:

mvn -pl extensions/opentelemetry/opentelemetry/runtime,extensions/opentelemetry/opentelemetry/deployment package

@gsmet
Copy link
Member

gsmet commented Jun 23, 2022

@brunobat I have this alias that you might find useful: alias format="mvnd process-sources -Denforcer.skip". It's using mvnd but you can use mvn -T1C if you don't use mvnd.

@gsmet
Copy link
Member

gsmet commented Jun 23, 2022

And please squash things: we are using merge commits for merging PRs for several reasons and we don't have the option to squash from the UI in this case.

Thanks!

@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet gsmet merged commit 8c9e419 into quarkusio:main Jun 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 27, 2022
@gsmet
Copy link
Member

gsmet commented Jun 27, 2022

Thanks!

@gsmet gsmet modified the milestones: 2.11 - main, 2.10.1.Final Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@radcortez radcortez radcortez approved these changes

@mamadaliev mamadaliev mamadaliev approved these changes

Assignees
No one assigned
Labels
area/tracing
Projects
None yet
Milestone
2.10.1.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brunobat @radcortez @gsmet @mamadaliev