Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about parent profile with profile aware files #26350

Merged
merged 1 commit into from Jul 1, 2022

Conversation

p1ass
Copy link
Contributor

@p1ass p1ass commented Jun 24, 2022

Summary

This pull request adds documentation of confusing behavior about parent profiles with parent-aware files.

Issue

we discussed it in issue #24586.

@@ -366,6 +366,12 @@ Then
* `quarkus.http.port` is 9090
* `quarkus.http.ssl-port` is 9443

[WARNING]
====
The configuration `quarkus.config.profile.parent` must be placed in the main `application.properties` file or passed as a system property.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also works if it is an Environment Variable.

@radcortez
Copy link
Member

Hi @p1ass

Thank you for the PR. I've left a small comment, to also add Environment Variable as an option.

@p1ass p1ass force-pushed the add-parent-profile-warning branch from 7b88e10 to 7468bcd Compare July 1, 2022 13:31
@p1ass
Copy link
Contributor Author

p1ass commented Jul 1, 2022

@radcortez I added it and rebased.

@radcortez
Copy link
Member

@radcortez I added it and rebased.

Great! Thanks!

@radcortez radcortez merged commit 3bba499 into quarkusio:main Jul 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 1, 2022
@p1ass p1ass deleted the add-parent-profile-warning branch July 1, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants