Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb panache docs for annotationProcessors #26355

Merged
merged 1 commit into from Jun 28, 2022

Conversation

edeandrea
Copy link
Contributor

update mongodb panache docs with annotationProcessor info

Closes #24637

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some small suggestions.

Thanks for using the tabs :).

docs/src/main/asciidoc/mongodb-panache.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/mongodb-panache.adoc Show resolved Hide resolved
@edeandrea
Copy link
Contributor Author

@gsmet what about MongoDB with Panache on Kotlin (https://quarkus.io/guides/mongodb-panache-kotlin)? Is there anything that needs to be updated there? I don't have much familiarity with Kotlin and don't know whether or not this annotation processor thing should be applied there too.

update mongodb panache docs with annotationProcessor info

Closes quarkusio#24637
@edeandrea
Copy link
Contributor Author

I also updated based on your suggestions @gsmet . I rebased back to a single commit as well.

@gsmet
Copy link
Member

gsmet commented Jun 27, 2022

I don't have much familiarity with Kotlin and don't know whether or not this annotation processor thing should be applied there too.

Your guess is as good as mine :).

/cc @evanchooly

@gsmet gsmet merged commit 1fc48b3 into quarkusio:main Jun 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 28, 2022
@loicmathieu
Copy link
Contributor

Thanks @edeandrea the same should be done for Hibernate ORM with Panache and Hibernate Reactive with Panache as they also need the annotation processor.

@edeandrea
Copy link
Contributor Author

@loicmathieu I just submitted #26435 to add the same documentation for Hibernate ORM with Panache & Hibernate Reactive with Panache.

I'm still unsure if it should be added to the Kotlin variants as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ReactivePanacheMongoEntity creates io.quarkus.bootstrap.classloading.QuarkusClassLoader error
3 participants